Skip to content

[codex] Phase 3H: chat scroll anchoring#18

Open
sukar0972 wants to merge 1 commit into
mainfrom
codex/phase3h-chat-scroll
Open

[codex] Phase 3H: chat scroll anchoring#18
sukar0972 wants to merge 1 commit into
mainfrom
codex/phase3h-chat-scroll

Conversation

@sukar0972

Copy link
Copy Markdown
Owner

Summary

  • add a shared chat-list anchor resolver for sent-message positioning
  • anchor newly sent optimistic messages in the web timeline and temporarily disable live-edge maintenance while anchored
  • add focused coverage for anchor resolution plus browser-harness coverage for the anchor scroll props

Upstream

  • adapts the web-safe chat scroll anchoring intent from upstream 24abab789
  • intentionally avoids desktop/browser-simulation and mobile/native scrolling changes

Grok Composer 2.5 review

  • initial Grok review blocked on maintainScrollAtEnd potentially fighting the sent-message anchor
  • fixed by disabling maintainScrollAtEnd while anchorMessageId is active and adding browser-harness coverage for the scroll props
  • second Grok review verdict: approve with suggestions; no blockers

Verification

  • vp test apps/web/src/components/chat/MessagesTimeline.test.tsx apps/web/src/components/chat/MessagesTimeline.logic.test.ts packages/shared/src/chatList.test.ts
  • vp run typecheck
  • vp check

Notes

  • vp test --project browser src/components/chat/MessagesTimeline.browser.tsx from apps/web could not run locally because Playwright Chromium is not installed in this environment (chrome-headless-shell missing). The browser spec typechecks and is included for environments with Playwright browsers installed.
  • Existing unrelated warnings remain: ProcessResourceMonitor.ts Effect suggestion during typecheck and pre-existing react(no-unstable-nested-components) warnings during vp check.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Jul 4, 2026
@sukar0972 sukar0972 marked this pull request as ready for review July 7, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant